Coachmark: Moved pulsingBeacon animation to styling package for reuse#4445
Closed
lynamemi wants to merge 4 commits intomicrosoft:masterfrom
Closed
Coachmark: Moved pulsingBeacon animation to styling package for reuse#4445lynamemi wants to merge 4 commits intomicrosoft:masterfrom
lynamemi wants to merge 4 commits intomicrosoft:masterfrom
Conversation
phkuo
approved these changes
Apr 3, 2018
Collaborator
Author
|
I just realized I'm not going to get a passing build in the ouifr package until I merge in the change to styling. I'll split these into two PRs. Here is the first: #4446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Moved the pulsingBeacon animation from Coachmark into its own file in the Styling package. Let me know if it makes more sense to you to put it somewhere else.
I will be reusing this animation for ActivityItem. The design and behavior has not changed.
Focus areas to test
(optional)